Тесты для бекенда

backend/app/routers/employees.py

@@ -1,47 +1,33 @@
-"""Employees router"""
+"""Employee router"""
 from fastapi import APIRouter, Depends, HTTPException, status
 from sqlalchemy.orm import Session
 from typing import List
 from ..database import get_db
 from ..crud import employees
 from ..schemas.employee import Employee, EmployeeCreate, EmployeeUpdate
-from ..utils.auth import get_current_admin
-from ..utils.auth import get_password_hash
+from ..utils.auth import get_current_admin, get_password_hash
 
 router = APIRouter()
 
-@router.post("", response_model=Employee)
+@router.post("/", response_model=Employee)
 def create_employee(
     employee: EmployeeCreate,
     db: Session = Depends(get_db),
     _: dict = Depends(get_current_admin)
 ):
-    """
-    Создание нового сотрудника (только для админа)
-    """
-    # Хэшируем пароль
+    """Create new employee"""
     hashed_password = get_password_hash(employee.password)
-    
-    # Создаем сотрудника
-    db_employee = employees.create_employee(
-        db=db,
-        employee=employee,
-        hashed_password=hashed_password
-    )
-    return db_employee
+    return employees.create_employee(db, employee, hashed_password)
 
-@router.get("", response_model=List[Employee])
+@router.get("/", response_model=List[Employee])
 def get_employees(
     skip: int = 0,
     limit: int = 100,
     db: Session = Depends(get_db),
     _: dict = Depends(get_current_admin)
 ):
-    """
-    Получение списка всех сотрудников (только для админа)
-    """
-    employees_list = employees.get_employees(db, skip=skip, limit=limit)
-    return employees_list
+    """Get all employees"""
+    return employees.get_employees(db, skip=skip, limit=limit)
 
 @router.get("/{employee_id}", response_model=Employee)
 def get_employee(
@@ -49,10 +35,8 @@ def get_employee(
     db: Session = Depends(get_db),
     _: dict = Depends(get_current_admin)
 ):
-    """
-    Получение информации о сотруднике по ID (только для админа)
-    """
-    db_employee = employees.get_employee(db, employee_id=employee_id)
+    """Get employee by ID"""
+    db_employee = employees.get_employee(db, employee_id)
     if db_employee is None:
         raise HTTPException(status_code=404, detail="Employee not found")
     return db_employee
@@ -64,35 +48,20 @@ def update_employee(
     db: Session = Depends(get_db),
     _: dict = Depends(get_current_admin)
 ):
-    """
-    Обновление информации о сотруднике (только для админа)
-    """
-    db_employee = employees.get_employee(db, employee_id=employee_id)
+    """Update employee data"""
+    db_employee = employees.update_employee(db, employee_id, employee)
     if db_employee is None:
         raise HTTPException(status_code=404, detail="Employee not found")
-        
-    # Если указан новый пароль, хэшируем его
-    if employee.password:
-        employee.password = get_password_hash(employee.password)
-        
-    updated_employee = employees.update_employee(
-        db=db,
-        employee_id=employee_id,
-        employee=employee
-    )
-    return updated_employee
+    return db_employee
 
-@router.delete("/{employee_id}")
+@router.delete("/{employee_id}", response_model=Employee)
 def delete_employee(
     employee_id: int,
     db: Session = Depends(get_db),
     _: dict = Depends(get_current_admin)
 ):
-    """
-    Удаление сотрудника (только для админа)
-    """
-    db_employee = employees.get_employee(db, employee_id=employee_id)
+    """Delete employee"""
+    db_employee = employees.delete_employee(db, employee_id)
     if db_employee is None:
         raise HTTPException(status_code=404, detail="Employee not found")
-    employees.delete_employee(db=db, employee_id=employee_id)
-    return {"message": "Employee deleted successfully"}
+    return db_employee